bwarren2 / datadrivendota

Codebase for dota analytics
Other
0 stars 0 forks source link

Apifollower refactor #541

Closed bwarren2 closed 8 years ago

bwarren2 commented 8 years ago

Per discussion, changing the function signature to the tasks that are downstream of ValveApiCall to: def run(self, api_context, json_data, response_code, url):

This lets us config tasks to handle the multitudinous ways Valve declares failure.

I have only hand-tested a player import and all the tasks in the celery schedule to be sure things work as expected; no real tests just yet because I am tired. However, this adds coverage (with some tech debt) to help keep track/make progress on that problem,

wlonk commented 8 years ago

LGTM :tea: