search

bwarren2 / datadrivendota

Codebase for dota analytics
Other
0 stars 0 forks source link

Plotly #583

Closed bwarren2 closed 8 years ago

bwarren2 commented 8 years ago

Uses a different charting lib. There is a loading difference, but performance is smoother after things are done.

Closes #571.

qimgdgn

wlonk commented 8 years ago

I love the amount of code removal this involves.

One thing I'm thinking from it is that inlining a little JS into your templates is OK, because it won't add to the bytes-sent-over-the-wire much, but more than a little gets bad, as you can't cache it, and so each request gets heavier. We should think about moving more of this JS out into static files soon. Though, that might also coincide with needing to move to a real frontend framework.

wlonk commented 8 years ago

:tea: :deciduous_tree:

bwarren2 commented 8 years ago

The code removal is nice. I wish I had known in the first place to do this and avoided writing all the chaff, but plotly was only open sourced like a year ago, right? Live and learn.