search

bwarren2 / datadrivendota

Codebase for dota analytics
Other
0 stars 0 forks source link

Show error on bad Steam login attempt. #610

Closed wlonk closed 8 years ago

wlonk commented 8 years ago

Putting the blame squarely on Steam's 503-ing shoulders.

Fixes #570.

wallaroo

wlonk commented 8 years ago

When DEBUG = True, the "show a useful error page" middlware will win, and you won't see the message, which is sad. But when it's false, you'll see an error message pop up instead of everything falling down.

wlonk commented 8 years ago

@bwarren2: I think the big thing this needs checking on is the text in the alert. I am not at all sure that that is quite the messaging we want. Thoughts?

bwarren2 commented 8 years ago

Tweaked the text, LGTM.