search

bwarren2 / datadrivendota

Codebase for dota analytics
Other
0 stars 0 forks source link

Initial UX work #638

Closed wlonk closed 8 years ago

wlonk commented 8 years ago

Per @amirtouray's feedback.

Some hacky untested stuff around showing parser-pipeline status.

bradypus

bwarren2 commented 8 years ago

Will there be cache busting problems if we are populating the status in the httpresponse?

Overall, looks good to me.

bwarren2 commented 8 years ago

Also, that is a great sloth.

wlonk commented 8 years ago

I'll have to look into our caching more; there are, potentially, cache problems there.

bwarren2 commented 8 years ago

I can take a stab at the JS approach if you would like.

wlonk commented 8 years ago

Nah, lemme focus on the caching first.

wlonk commented 8 years ago

Incidentally, our REST API endpoints had excessive caching. We had no DEFAULT_CACHE_RESPONSE_TIMEOUT set; see the docs.

I think we can shorten our CACHE_MIDDLEWARE_SECONDS env variable, too.

wlonk commented 8 years ago

(Still investigating caching behavior.)

wlonk commented 8 years ago

Looks like it'll be OK? Not super confident in that, but we can always revert in prod if it misbehaves.

wlonk commented 8 years ago

I think this is ready to merge and push when you like it.