bwdutton / gallery3

The simplest, most intuitive way to host your photos on your website.
https://galleryrevival.com/
GNU General Public License v2.0
131 stars 26 forks source link

Problem after switching from Gallery3 Git to Gallery Revival #27

Open phermsdorf opened 1 year ago

phermsdorf commented 1 year ago

Hi,

at first i wanted to thank you that you keep the gallery project alive!

I was previously running on the git version of gallery3 and now just swiched the remote to this repository. After logging in i see an error which is also in the gallery log:

128 /**
129  * Iterator: key
130  */
131 public function key(): mixed
132 {
133     return $this->current_row;
134 }
135
136 /**
137  * Iterator: next
138  */
2023-07-08 13:17:01 +00:00 --- error: TypeError [ 0 ]: Return value of Database_Result_Core::key() must be an instance of mixed, int returned
/var/www/vhosts/mysite.de/htdocs/g3_master/system/libraries/Database_Result.php [ 133 ]
#0 /var/www/vhosts/mysite.de/htdocs/g3_master/system/libraries/ORM_Iterator.php(198): Database_Result_Core->key()
#1 /var/www/vhosts/mysite.de/htdocs/g3_master/themes/wind_my/views/album.html.php(11): ORM_Iterator_Core->key()
#2 /var/www/vhosts/mysite.de/htdocs/g3_master/system/libraries/View.php(318): include('/var/www/vhosts...')
#3 /var/www/vhosts/mysite.de/htdocs/g3_master/system/libraries/View.php(260): View_Core->load_view()
#4 /var/www/vhosts/mysite.de/htdocs/g3_master/modules/gallery/libraries/MY_View.php(75): View_Core->render()
#5 /var/www/vhosts/mysite.de/htdocs/g3_master/system/libraries/View.php(226): View->render()
#6 /var/www/vhosts/mysite.de/htdocs/g3_master/themes/wind_my/views/page.html.php(119): View_Core->__toString()
#7 /var/www/vhosts/mysite.de/htdocs/g3_master/system/libraries/View.php(318): include('/var/www/vhosts...')
#8 /var/www/vhosts/mysite.de/htdocs/g3_master/system/libraries/View.php(260): View_Core->load_view()
#9 /var/www/vhosts/mysite.de/htdocs/g3_master/modules/gallery/libraries/MY_View.php(75): View_Core->render()
#10 /var/www/vhosts/mysite.de/htdocs/g3_master/system/libraries/View.php(226): View->render()
#11 /var/www/vhosts/mysite.de/htdocs/g3_master/modules/gallery/controllers/albums.php(77): View_Core->__toString()
#12 /var/www/vhosts/mysite.de/htdocs/g3_master/modules/gallery/controllers/albums.php(22): Albums_Controller->show()
#13 [internal function]: Albums_Controller->index()
#14 /var/www/vhosts/mysite.de/htdocs/g3_master/system/core/Kohana.php(302): ReflectionMethod->invokeArgs()
#15 /var/www/vhosts/mysite.de/htdocs/g3_master/system/core/Event.php(208): Kohana_Core::instance()
#16 /var/www/vhosts/mysite.de/htdocs/g3_master/application/Bootstrap.php(67): Event_Core::run()
#17 /var/www/vhosts/mysite.de/htdocs/g3_master/index.php(124): require('/var/www/vhosts...')
#18 {main}

What could be the cause? I removed all local changes ... I also tried to switch to the default wind and wide wind theme with no luck.

Thanks for any hints on this!

Bye Peter

PrplHaz4 commented 5 months ago

It appears the download of the zip file from the website does not include any of the php8 fixes. Download master from github directly and it will probably fix those errors you're seeing.