search

bwentzloff / trading-bot

Code seen in Cryptocurrency Trading YouTube video here: https://youtu.be/fpqzXgZjSqM
400 stars 262 forks source link

Backtest date #22

Open davaux opened 6 years ago

davaux commented 6 years ago

Hello, I don't understand something about the backtest dates using the BotCandleStick object.
For the backtest the startTime for your BotCandleStick should be the past date from the result of chart data request no ? but in the BotCandleStick the startTime is still time.time() weather its for backtest or live. Also if we want to plot with backtest past dates we then need another object that hold the past dates.

bwentzloff commented 6 years ago

You’re correct. That’s an error. I’ll get that fixed today.

On Sep 27, 2017, at 1:48 AM, davaux notifications@github.com wrote:

Hello, I don't understand something about the backtest dates using the BotCandleStick object. For the backtest the startTime for your BotCandleStick should be the past date from the result of chart data request no ? but in the BotCandleStick the startTime is still time.time() weather its for backtest or live. Also if we want to plot with backtest past dates we then need another object that hold the past dates.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bwentzloff/trading-bot/issues/22, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHH6wI3VDfaduwwwG1zIUbbRez5v9IRks5sme_CgaJpZM4PlSv-.

davaux commented 6 years ago

Actually I tried the bot and I think for backtesting the strategy the actual date of the backtest data is not that important. And for plotting the data on the chart having another structure is not so bad. Thank you for your videos and your bot.