bwgjoseph / mongoose-vs-ottoman

feature comparison between mongoose and ottoman
0 stars 1 forks source link

Removal of username, password, trustStorePath etc from ConnectOptions #108

Closed bwgjoseph closed 3 years ago

bwgjoseph commented 3 years ago

Hi,

I notice that the recent change to ConnectOptions removed quite a number of properties.

Previously, I connect as such

ottoman.connect({
    connectionString: 'couchbase://localhost',
    bucketName: 'testBucket',
    username: 'user',
    password: 'password',
  });

Now, I can only connect with

ottoman.connect('couchbase://localhost/testBucket@user:password');

The docs still showing the username, password way of connecting - https://ottomanjs.com/guides/quick-start.html#connecting-to-a-couchbase-bucket

Changes done in this commit https://github.com/couchbaselabs/node-ottoman/commit/6ab72220b3b3a7f71c0b3f8d3321aeb65999c47f#diff-d37b052f6aba3859ca946e577d821bcd46f834043744f0926a6f334e7db60def

How do I do so in the future?

Thanks

AV25242 commented 3 years ago

Nothing has changed @bwgjoseph
The code has been refactored to extend CouchbaseConnectOptions

export interface ConnectOptions extends CouchbaseConnectOptions {

image

Things should work as before, please let us know if thats not the case

bwgjoseph commented 3 years ago

Yup, I can't.

image

If you have been using the same node_modules in your machine, it will work. Try removing the entire node_modules and package-lock.json and run npm i again.

Not sure if it has something to do with #104.

image

AV25242 commented 3 years ago

Hello @bwgjoseph both Eric and I tried but we were successful.

Screen Shot 2021-09-10 at 3 51 26 PM

Can you please confirm which versions of Ottoman and Couchbase you are using? We are on Ottoman: 2.0.0-beta.8 & Couchbase 3.2.1

Can you confirm the version of these two packages you have installed with NPM!

We believe that you are using Couchbase 3.1 and it is breaking Ottoman. The recommendation is to remove the Couchbase package from your project and let Ottoman handle it.

Otherwise, you can change your Couchbase package in your project to 3.2.1 but this is not recommended because you are overriding. SO unless you are using the NodeJS SDK for something in your project directly, you should remove it.

Version 3.1 does not provide any definition types.

bwgjoseph commented 3 years ago

Thank you Arun and Eric!

Based on what you mentioned, I went to check, and verify the ottoman version, and it is correct. But I figured out the problem was because of mixed ottoman package installed.

I installed ottoman-2.0.0-beta.8 on my project, but also had feathers-ottoman-0.3.1 installed on my project. Thing is that feathers-ottoman still hasn't upgrade to beta.8 (currently on beta.3 and I think that's the problem where there is beta.3 and .8 in my project which cause the problem.

Apologies for the confusion. I tested on my brand new project, and only installed beta.8, and it does work.

AV25242 commented 3 years ago

Hi @bwgjoseph can this issue be closed then ?