search

bwgjoseph / mongoose-vs-ottoman

feature comparison between mongoose and ottoman
0 stars 1 forks source link

Discrepancy in ModelTypes and IModel types #70

Closed bwgjoseph closed 3 years ago

bwgjoseph commented 3 years ago

Hi,

In model.types.d.ts, it has 

export declare type ModelTypes<T = any> = WhateverTypes & IModel<T>;

But in model.d.ts, it has

export declare class Model<T = any, R = any> extends Document<T>

export interface IModel<T = any, R = any>

So IModel takes in T, R but ModelTypes takes in T and only passes T to IModel

Not sure if this is the intended

alpha.28

AV25242 commented 3 years ago

https://github.com/couchbaselabs/node-ottoman/issues/471 created

AV25242 commented 3 years ago

Investigation done. This will be fixed with the next release

httpJunkie commented 3 years ago

Fixed w/ alpha 29