search

bwgjoseph / mongoose-vs-ottoman

feature comparison between mongoose and ottoman
0 stars 1 forks source link

standardize searchConsistency field name #77

Closed bwgjoseph closed 3 years ago

bwgjoseph commented 3 years ago

Hi,

In FindOptions, the fieldname is currently defined as consistency but in OttomanConfig, it is defined as searchConsistency.

I was wondering why it wouldn't work when I was using searchConsistency and placing it in the findOptions when using find API. After hours, then I saw that the naming is not the same.

Note: when using cluster query, it is called scanConsistency

await getDefaultInstance().cluster.query(query, { scanConsistency: 'request_plus' });

Thanks

AV25242 commented 3 years ago

Thanks names should be consistent

https://github.com/couchbaselabs/node-ottoman/issues/464 created

httpJunkie commented 3 years ago

Fixed w/ alpha 29

bwgjoseph commented 3 years ago

OttomanConfig has changed to consistency but I am unable to verify if query has changed

httpJunkie commented 3 years ago

The word scanConsistency is now 'consistencyacrossfind()andupdateMany()andOttomanConfig`

concerning: "OttomanConfig has changed to consistency but I am unable to verify if query has changed"

query is a node SDK thing.

bwgjoseph commented 3 years ago

Since scanConsistency is the node-sdk fieldname, will keep it as is