search

bwheelz36 / ParticlePhaseSpace

Import, analysis, and export of particle phase space data
https://bwheelz36.github.io/ParticlePhaseSpace/
GNU General Public License v3.0
11 stars 8 forks source link

Joss review benjamin #152

Closed bwheelz36 closed 1 year ago

bwheelz36 commented 1 year ago

Hi @benjaminbolling

I've made changes to your issues in this PR. I will leave it open until you let me know you are satisfied with the responses!

bwheelz36 commented 1 year ago

oops I didn't intent to include #144 in this - will make a new PR.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.07 :warning:

Comparison is base (64478fd) 85.70% compared to head (2b67395) 85.64%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #152 +/- ## ========================================== - Coverage 85.70% 85.64% -0.07% ========================================== Files 8 8 Lines 1154 1156 +2 ========================================== + Hits 989 990 +1 - Misses 165 166 +1 ``` | [Impacted Files](https://app.codecov.io/gh/bwheelz36/ParticlePhaseSpace/pull/152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [ParticlePhaseSpace/\_\_phase\_space\_config\_\_.py](https://app.codecov.io/gh/bwheelz36/ParticlePhaseSpace/pull/152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-UGFydGljbGVQaGFzZVNwYWNlL19fcGhhc2Vfc3BhY2VfY29uZmlnX18ucHk=) | `91.30% <ø> (ø)` | | | [ParticlePhaseSpace/\_ParticlePhaseSpace.py](https://app.codecov.io/gh/bwheelz36/ParticlePhaseSpace/pull/152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-UGFydGljbGVQaGFzZVNwYWNlL19QYXJ0aWNsZVBoYXNlU3BhY2UucHk=) | `89.40% <66.66%> (-0.16%)` | :arrow_down: | | [ParticlePhaseSpace/DataLoaders.py](https://app.codecov.io/gh/bwheelz36/ParticlePhaseSpace/pull/152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-UGFydGljbGVQaGFzZVNwYWNlL0RhdGFMb2FkZXJzLnB5) | `80.85% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.