bwhmather / ssort

Tool for automatically sorting python statements within a module

MIT License

360 stars 10 forks source link

Fix #78: unresolved dependency 'path' in 'init.py' #82

Closed cgahr closed 1 year ago

cgahr commented 1 year ago

Fix #78

bwhmather commented 1 year ago

Is there something we could have added to test_builtins.py that would have caught this?

bwhmather commented 1 year ago

I think @jgberry wins this one with https://github.com/bwhmather/ssort/pull/85. I think he's right that ssort already has many false negatives, and that this isn't really a problem.

jgberry commented 1 year ago

Is there something we could have added to test_builtins.py that would have caught this?

85 also addresses this by adding a number of new test cases to `test_builtins.py`. These tests revealed we are also missing the following builtins in addition to `path`:

__annotations__
__builtins__
__cached__

cgahr commented 1 year ago

Superseded by #85

bwhmather / ssort

Fix #78: unresolved dependency '__path__' in '__init__.py' #82

85 also addresses this by adding a number of new test cases to test_builtins.py. These tests revealed we are also missing the following builtins in addition to __path__:

Fix #78: unresolved dependency 'path' in 'init.py' #82

85 also addresses this by adding a number of new test cases to `test_builtins.py`. These tests revealed we are also missing the following builtins in addition to `path`: