search

bwhmather / ssort

Tool for automatically sorting python statements within a module
MIT License
359 stars 10 forks source link

Refactor step 2: replace Node traversal with ast.NodeVisitor #93

Closed cgahr closed 1 year ago

cgahr commented 1 year ago

depends on #91 see #92 for discussion.

jgberry commented 1 year ago

Yep, see #42 for the performance related discussion. This was a decision we consciously made. Whether it was the right decision, perhaps that can be revisited. There are tradeoffs on either side.

cgahr commented 1 year ago

I see that now.

I did some performance profiling too and found similar results..