bwinton / TabCenter

Firefox add-on for arranging tabs vertically
https://testpilot.firefox.com/experiments/tab-center
208 stars 55 forks source link

Throbber / spinner appears as a rotating white box #1038

Closed hcs64 closed 7 years ago

hcs64 commented 7 years ago

On currently nightly (build 20170329071901 on OS X and Win 7), the spinner is rendering as a rotating white box with rounded corners:

screen shot 2017-03-29 at 4 01 59 pm

mozregression led me to this changeset from bug 759252, so it seems like it is related to this recent change.

SoftVision-PaulOiegas commented 7 years ago

Seen this also yesterday but somehow I was convinced that it's a new feature lol. Thanks for the report ! 😄

ericawright commented 7 years ago

Yes, on nightly this has been happening as a result of that bug landing the other day. But, I kind of think it's cute. Unfortunately it just disappears entirely when tabs are small, so it is something that will need to change eventually.

mlissner commented 7 years ago

I think I saw that Firefox is working on redoing the spinners, so I assume that's what breaking things here, but on nightly I'm not seeing a spinner at all. When a page is loading, I just have a space where the favicon would normally be until the page loads and then I see the favicon. It's surprisingly disorienting not to have anything showing progress of a page loading.

(Nightly on Ubuntu Linux with dark theme.)

hcs64 commented 7 years ago

@mlissner: As ericawright mentioned, the spinning empty favicon holder only shows up when the tabs are full sized (with a thumbnail and domain). Do you have enough tabs that it is showing the small version of tabs with only the favicon and title?

mlissner commented 7 years ago

Ah, I missed that, @hcs64. I have the setting enabled that makes the tabs small all the time (the shrinking and expanded drove me nuts). So yeah, sounds like @ericawright is on this!

mlissner commented 7 years ago

Thank you!

asamuzaK commented 7 years ago

Not fix yet. Spinner is spinning WITH a white background (blue background in compact themes).

ericawright commented 7 years ago

@asamuzaK for now, we've decided that that's okay. so long as the spinner hasn't disappeared