search

bwinton / TabCenter

Firefox add-on for arranging tabs vertically
https://testpilot.firefox.com/experiments/tab-center
210 stars 56 forks source link

Search results should not lead to (more) tabs that do not match what's sought #1094

Open grahamperrin opened 7 years ago

grahamperrin commented 7 years ago

It makes no sense to show:

n more tabs…

– when none matches what's sought.

Re: #437 Esc escaping does now clear the search field, so I can't think of a good reason to offer to show more non-matching tabs in the context of search results.

SoftVision-CiprianMuresan commented 7 years ago

Hi @grahamperrin, thanks for the report. The title of the issue sounds a lot like #1004. But the contents of the issue refer to the "n more tabs".

Is the issue about:

  1. Tabs that are not filtered correctly? OR
  2. Showing "n more tabs" when no tabs match the filter?
grahamperrin commented 7 years ago

Thanks for asking. It's close to (2).

Showing 'n more tabs' when some tabs, or no tabs, match.

ericawright commented 7 years ago

thanks for the report grahamperrin, the "n more tabs..." button is so that the searcher has an easy way to get back to their tab list if they do not find what they are searching for. That way people don't lose the tabs, or think we have closed them.

grahamperrin commented 7 years ago

It's peculiar.

A less peculiar approach might be something like a Clear icon in the search field.