Browser windows sometimes get corrupted after disabling the add-on

[pdehaan]

Found in today's v1.10 build, but I've occasionally seen this earlier as well.

After disabling the add-on, the UI doesn't return to it's original state, and requires me to force-quit the add-on.

[jaredhirsch]

There are a lot of bugs in the add-on that aren't resolved by removing the add-on, but are resolved by removing / disabling, then restarting. This bug report might correspond to any of the known open bugs, or some unknown ones, so it's probably too general to be investigated.

I vote for closing it, @bwinton's call though.

[pdehaan]

@6a68 Here's an example of me stopping the TabCenter experiment through Test Pilot.

Resizing the browser didn't solve anything, and the only way I could get my browser usable again was to switch to fullscreen mode on OS X and then exit fullscreen.

[bwinton]

Can we get a copy of the Browser Console log first, to see if we can identify what's going wrong?

Sent from my iPod Touch.

On Apr 19, 2016, at 12:02, Jared Hirsch notifications@github.com wrote:

There are a lot of bugs in the add-on that aren't resolved by removing the add-on, but are resolved by removing / disabling, then restarting. This bug report might correspond to any of the known open bugs, or some unknown ones, so it's probably too general to be investigated.

I vote for closing it, @bwinton's call though.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

[pdehaan]

Not sure how much (if any) of this helps, but it looks like all the "pad.js" stuff is from etherpad.

This error pops up a few times though and may be a bit suspect:

_"Could not read chrome manifest 'file:///Users/pdehaan/dev/tmp/ff-tool/temp/browsers/FirefoxBeta.app/Contents/Resources/chrome.manifest'."

---

[bwinton]

Also, how does Test Pilot uninstall add-ons?

[pdehaan]

I think this is the TestPilot uninstallExperiment() code we seek:

function uninstallExperiment(experiment) {
  if (isTestpilotAddonID(experiment.addon_id)) {
    AddonManager.getAddonByID(experiment.addon_id, a => {
      if (a) { a.uninstall(); }
    });
  }
}

via /addon/index.js:346-352

/cc @meandavejustice @lmorchard

[meandavejustice]

Indeed. It is.

[pdehaan]

... I cannot reproduce this issue w/ my Nightly browser.

In fact, here's the output of my Browser Console (with all my other add-ons disabled):

So I'm seeing the same "Could not read chrome manifest" message, and the "expression closures are deprecated" warning messages seem to come from /utils.js:63.

[bwinton]

@pdehaan Just as a question, do you have more than one Firefox window open when this happens?