search

bwinton / TabCenter

Firefox add-on for arranging tabs vertically
https://testpilot.firefox.com/experiments/tab-center
210 stars 56 forks source link

"Block pop-up windows" ignores exception list #636

Open merlin67 opened 7 years ago

merlin67 commented 7 years ago

I have several sites (including my banking site) which opens a new tab when I click links. TabCenter immediately closes these new tabs every time, even though I have the sites listed in my exception list.

ericawright commented 7 years ago

This is very odd, just to confirm, if you disable TabCenter the new tabs open correctly?

merlin67 commented 7 years ago

Yes, they do, which is why it is so frustrating. I’ve had to shut off tabcenter because of it

From: Erica [mailto:notifications@github.com] Sent: Tuesday, September 27, 2016 10:44 AM To: bwinton/TabCenter TabCenter@noreply.github.com Cc: merlin67 merlin67@gmail.com; Author author@noreply.github.com Subject: Re: [bwinton/TabCenter] "Block pop-up windows" ignores exception list (#636)

This is very odd, just to confirm, if you disable TabCenter the new tabs open correctly?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bwinton/TabCenter/issues/636#issuecomment-249923782 , or mute the thread https://github.com/notifications/unsubscribe-auth/AVb-7QpKIK3JBi8zp1qZt-wrC74_fNKdks5quUfegaJpZM4KH3IT . https://github.com/notifications/beacon/AVb-7YsFXCpU1Dw_cOxwKnHPISKIvE-2ks5quUfegaJpZM4KH3IT.gif

ericawright commented 7 years ago

can you give me the steps to reproduce?

merlin67 commented 7 years ago

well, that is difficult since the most common one is my banking site, and I can't exactly give you access to that... would have to think of another site it does it on.

ericawright commented 7 years ago

no, of course not. But perhaps I use the same site? So I assume that this is the setting you have on that generally blocks the pop up windows? from about:preferences:

screen shot 2016-09-27 at 10 25 02 am

And you've added your bank to the exception list. Is there anything else you can think of that might be interacting with this?

merlin67 commented 7 years ago

Well, the site is HSBCnet. Yes, that is the setting I am talking about, and my bank is in the exception list. I'm not a coder, so I don't know for sure, but one explanation for this may be the way the site opens pop ups. when I right-click on the link to see the information, it is a javascript command. would that have an effect?

ericawright commented 7 years ago

okay, last thing, can you let me know which link/button it is that you click on?

merlin67 commented 7 years ago

Anything that goes to a different page, whether it is my "account details" page, or a bill payment page

ericawright commented 7 years ago

okay, thank you for the info, I'll see what I can do! (if you see it happen on any other site please let me know)

merlin67 commented 7 years ago

Thanks, will do!