search

bwinton / TabCenter

Firefox add-on for arranging tabs vertically
https://testpilot.firefox.com/experiments/tab-center
208 stars 55 forks source link

Can't disable with Beyond Australis #783

Open Quicksaver opened 7 years ago

Quicksaver commented 7 years ago

Tab Center has issues unloading when used together with Beyond Australis and its Slim Chrome feature. That's because when unloading, it's trying to insert the tabs toolbar based on the navigation toolbar, which isn't a child of #navigator-toolbox in this case - Slim Chrome moves the #nav-bar out of there. So it completely fails to unload.

Both add-ons themselves seem to work fine, it's only when disabling Tab Center (such as on updates, which makes it a huge deal!) that it has trouble. Please let me know if there's anything I can do, although I'm not sure there's much I can do on my end to avoid this.

Note, try to test with the code from master because the latest version on AMO is a little glitchy on its own. ;)

Quicksaver commented 7 years ago

How about:

let menubar = document.getElementById('toolbar-menubar');
let sibling = toolbox.firstChild;
if(sibling && sibling == menubar) {
  sibling = sibling.nextSibling;
}
toolbox.insertBefore(toolbar, sibling);

PS. Working on trying to disable Slim Chrome before Tab Center does to prevent this. It's tricky, but if I can figure it out at least users won't have any trouble on the next update at least (if I can release an update before Tab Center of course).

Quicksaver commented 7 years ago

Well that was easier than I thought: https://github.com/Quicksaver/The-Fox--Only-Better/commit/41004e1f8adba939c88960c0717ffbac2b33c4d0, although it's not optimal (it's a slow process, lots of things moving around, very noticeable), so a fix on Tab Center's side like the one I proposed would definitely be more efficient. :)

I hope to push an update between this and next week, although I can't be positive of when it will happen exactly. But I will try to do it before Tab Center is updated, to avoid any users having issues updating Tab Center. Do you have any planned schedule for Tab Center?

Quicksaver commented 7 years ago

BTW also affects the new "Move tabs to top" button but there's not a lot for me to do with that one right now since it's not in the latest Tab Center's release. ;)

xerz-one commented 7 years ago

How's the current progress of this issue? @Quicksaver, did you do a pull request yet? I just tried out and found out the same problem, so I'd be great if you could fix it…

Edit: the problem has only happened to me once, reloading Firefox while Slim Chrome was disabled seemed to fix it for me.