bwinton / TabCenter

Firefox add-on for arranging tabs vertically
https://testpilot.firefox.com/experiments/tab-center
209 stars 55 forks source link

The change from "big" tabs to "small" tabs is very slow #833

Open Cultrarius opened 7 years ago

Cultrarius commented 7 years ago

When I open about 20 tabs they change size from big to small, which animates really slow. This is really annoying when opening a few tabs and immediately closing them again (e.g. search results), because then the change happens very often and becomes very noticeable.

SoftVision-PaulOiegas commented 7 years ago

Hi @Cultrarius and thanks for your report. I've tried to reproduce this behavior but the animation takes less than 1 second in my case, and occurs after about 18 tabs opened. Of course if the sidebar is not focused, the animation does not occur if you are focusing it.

Can you provide some detailed steps on how you reproduce this ? Or even better, can you make a screen recording of this issue ? Maybe I'm not doing the same steps as you do.

Cultrarius commented 7 years ago

Hey @SoftVision-PaulOiegas sorry for being not very precise with my description of the problem. When I said "really slow" I did not mean that it takes several seconds, but that there is a visible lag in the animation and that firefox becomes briefly unresponsive (eating one or two mouseclicks which is annoying).

Have a look at the following screencast I made: https://youtu.be/ROqp0cRdenw If you look closely, the animation to minify the tabs runs faster than the animation to expand them. Also, the expansion animation visibly stutters (this is not an artifact of the screen recording). My guess would be fetching/displaying the preview thumbnail images is the culprit here.

Also, have a look at the 0:13 mark, I try to close the three tabs I just opened by very rapidly clicking the middle mouse button, but almost all of the clicks are eaten by the lag and ignored! It takes me almost 3 seconds to close the tabs (normally this takes less than a second). Somewhere TabCenter creates a few ms delay which may not seem like much, but it feels very sluggish. This is especially noticeable when working in parallel with another browser like chrome where there is no delay.

Great work on the extension by the way, keep up the good work :)