bwinton / TabCenter

Firefox add-on for arranging tabs vertically
https://testpilot.firefox.com/experiments/tab-center
210 stars 55 forks source link

DEPRECATION WARNING: This path to Console.jsm is deprecated #98

Closed pdehaan closed 8 years ago

pdehaan commented 8 years ago

"DEPRECATION WARNING: This path to Console.jsm is deprecated. Please use Cu.import("resource://gre/modules/Console.jsm") to load this module."

Randomly spotted this in Browser Console, and it seems to trace back to verticaltabs.jsm:43:

DEPRECATION WARNING: This path to Console.jsm is deprecated.  Please use Cu.import("resource://gre/modules/Console.jsm") to load this module.
You may find more details about this deprecation at: https://bugzil.la/912121
resource://gre/modules/devtools/Console.jsm 19 null
resource://tabcenter/verticaltabs.jsm 43 null
resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///Users/pdehaan/dev/github/ff-tool/_temp/profiles/fftool.yBtyzD/extensions/tabcentertest1@mozilla.com.xpi!/bootstrap.js 97 startup
resource://gre/modules/addons/XPIProvider.jsm 4758 this.XPIProvider.callBootstrapMethod
resource://gre/modules/addons/XPIProvider.jsm 6218 AddonInstall.prototype.startInstall/<
resource://gre/modules/Task.jsm 319 TaskImpl_run
resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js 937 Handler.prototype.process
resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js 816 this.PromiseWalker.walkerLoop
browser_console_and_tech-gadgets
bwinton commented 8 years ago

Yeah, we should fix this. It looks like resource://gre/modules/Console.jsm is available in Release now, so we can just go ahead and make the change. (But it's not that important, so I'm marking it as post-release.)

ericawright commented 8 years ago

this has been "fixed" console was not used, so was removed

Croydon commented 8 years ago

It is possible to use console without requiring anything anyway. I'm assuming that this wasn't the case a few years ago or something like that..

bwinton commented 8 years ago

Well, normally that's true, but not in the context this code is running in…