search

bwinton / whimsy

An addon to add some whimsperiments to your Firefox…
64 stars 59 forks source link

Whimsy appears to break history (at least, in e10s) #100

Closed mozkeeler closed 9 years ago

mozkeeler commented 10 years ago

Recently new history items started not showing up in my history while browsing. I thought it was due to e10s (see https://bugzilla.mozilla.org/show_bug.cgi?id=1101205 ), but after disabling Whimsy, the problem went away.

bwinton commented 10 years ago

So, I can't replicate this, and Whimsy doesn't do anything history-related, so I'm not sure how to debug it. Can you get the code, and try grunt run-ing the add-on to see if you can get me some steps-to-reproduce?

mikeconley commented 10 years ago

Hey mozkeeler,

Can you provide a list of your other enabled add-ons? (about:support). It's possible that Whimsy is interacting poorly with another add-on to produce this effect.

The Interest Dashboard add-on, for example, has been causing strange conflicts with other add-ons recently.

-Mike

mozkeeler commented 10 years ago

Looks like Adblock Plus + Whimsy are causing this (but not either by itself). STR appear to be: install both, restart firefox, try visiting new sites.

strugee commented 10 years ago

I can reproduce this issue, but I don't have AdBlock Plus installed. Here's my extension list:

Name Version Enabled ID About startup 0.1.12 true aboutstartup@glandium.org about:me 0.7 true aboutme@test.mozilla.com Add-on Compatibility Reporter 2.0.4 true compatibility@addons.mozilla.org BetterPrivacy 1.68 true {d40f5e7b-d2cf-4856-b441-cc613eeffbe3} Chat Reply Helper for Stack Exchange sites 2.4.1 true {6DF67709-ECE1-4252-BC58-BA8E2320DA7E} Cycle Collector Analyzer, about:ccdump 0.4.3 true ccdump@getfirebug.com GNotifier 1.8.6 true jid1-OoNOA6XBjznvLQ@jetpack Greasemonkey 2.3 true {e4a8a97b-f2ed-450b-b12d-ee082ba24781} HTTPS-Everywhere 4.0.2 true https-everywhere@eff.org Lightbeam 1.0.10.2 true jid1-F9UJ2thwoAm5gQ@jetpack Monkeysphere 0.8 true tls-xul-ext@monkeysphere.info Mozilla Labs: Prospector - Home Dash 11 true home.dash@prospector.labs.mozilla PDF Viewer 1.0.277 true uriloader@pdf.js Restart 1.2.3 true Restart@schuzak.jp Terms of Service; Didn’t Read 0.4 true jid0-3GUEt1r69sQNSrca5p8kx9Ezc3U@jetpack YouTube ALL HTML5 2.1.3 true jid1-qj0w91o64N7Eeg@jetpack YSlow 3.1.8 true yslow@yahoo-inc.com about:accessibilityenabled 1.4 false {7a40e08d-6eb6-430c-8104-422341c54cb2} about:telemetry 0.14 false ping.telemetry@mozilla.com Adblock Plus 2.6.6 false {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d} Add-on Builder Helper (discontinued) 1.8.final false jid0-t3eeRQgGANLCH9c50lPqcTDuNng@jetpack Annotary Toolbar 0.8.3 false jid1-d0WNmlonBLGJig@jetpack Beef Taco (Targeted Advertising Cookie Opt-Out) 1.3.7 false john@velvetcache.org Cheevos 1.5 false jid1-bpzDizt9E1R7nw@jetpack Cloud To Butt 1.1 false cloud-to-butt-mozilla@github.com Config Descriptions 1.0 false {1823e248-6bf4-f6f1-7901-65a68e8b6c1e} Convergence Extra 0.11.20140409205855 false convergence@extension.fraggod.net Desktop notifications for Stack Exchange's inbox 1.6.6 false stackexchange-notifications@jetpack DNSSEC/TLSA Validator 2.1.2 false dnssec@nic.cz Dojo Firebug Extension 1.1.4 false dojo@silvergate.ar.ibm.com dotjs 1.10 false jid0-HC7vB1GcMVr7IBB5B5ADUjTJB3U@jetpack Favorite Users - Stack Exchange 1.4.1 false sefu@michalbures.com Firebug 2.0.6 false firebug@software.joehewitt.com Firemacs 4.5 false {e98b7313-167d-48c6-89be-bc514d6de8d9} FirePHP 0.7.4 false FirePHPExtension-Build@firephp.org FoxyProxy Standard 4.4.1 false foxyproxy@eric.h.jung Ghostery 5.4.1 false firefox@ghostery.com GNOME keyring password integration 0.2 false gnomekeyring@guillermo.molina GNOME Theme Tweak 33.2 false {05f1cdaa-7474-43fa-9f69-c697555f4ea8} Greasefire 1.0.8 false greasefire@skrul.com Heartbleed Notifier 0.1.1 false heartbleed@dactyl.googlecode.com Illuminations for Developers 1.1.29 false sroussey@illumination-for-developers.com It's All Text! 1.8.1 false itsalltext@docwhat.gerf.org KBD Button for Stack Exchange sites 0.2.0 false {0CD782A3-E906-4CD9-9107-CE5E030DEBD4} Leet Key 1.4.3 false {3335F91D-2AEF-4097-B831-C96C60349822} LiveReload 0.6.4 false livereload@livereload.com Location Bar Enhancer 5.1 false UIEnhancer@girishsharma Masking Agent 1.3.0 false maskingagent@basa.nl MemChaser 0.6 false memchaser@quality.mozilla.org Mozilla Labs: Prospector - Instant Preview 5 false instant.preview@prospector.labs.mozilla Mozilla Labs: Prospector - OneLiner 2 false oneLiner@prospector.labs.mozilla Mozilla Labs: Prospector - Search Tabs 1 false search.tabs@prospector.labs.mozilla Mozilla Labs: Prospector - Speak Words 9 false speak.words@prospector.labs.mozilla Mozilla Labs: Prospector - Tab Focus 2 false tabfocus@prospector.labs.mozilla Mozmill Crowd 0.2 false mozmill-crowd@quality.mozilla.org Nightly Tester Tools 3.7 false {8620c15f-30dc-4dba-a131-7c5d20cf4a29} NoScript 2.6.9.4 false {73a6fe31-595d-460b-a920-fcc0f8843232} Plus One Button 1.0.3.2 false plusone-button@oliver.schloebe.de Privacy Badger Firefox 0.1.4 false jid1-MnnxcxisBPnSXQ@jetpack Recall Monkey 22 false recallmonkey@prospector.labs.mozilla RequestPolicy 0.5.28 false requestpolicy@requestpolicy.com RequestPolicy Sync 0.1.6 false {02c6f6b9-d610-4e7e-9441-243c96c8dfab} Restartless Restart 9 false restartless.restart@erikvold.com Self-Destructing Cookies 0.4.6 false jid0-9XfBwUWnvPx4wWsfBWMCm4Jj69E@jetpack SPDY indicator 2.1 false spdyindicator@chengsun.github.com Stack Exchange Manager 0.00b1 false {7158FC09-2CFF-4562-9D6A-D8C64CA9FF7C} Status Watch 0.3 false jid0-arVzmwkosQBcRjPzByNer1jkTVg@jetpack Stylish 1.4.3 false {46551EC9-40F0-4e47-8E18-8E5CF550CFB8} Test Pilot 1.2.3 false testpilot@labs.mozilla.com Tumblr Savior 0.4.13 false jid1-W5guVoyeUR0uBg@jetpack UAControl 0.1.3.1 false uacontrol@qz.tsugumi.org Ubiquity 0.6 false ubiquity@labs.mozilla.com User Agent RG 1.0 false useragentrg@mozilla.org Web Developer 1.2.5 false {c45c406e-ab73-11d8-be73-000a95be3b12} Whimsy Pro 1.0.2 false jid1-6mUPixNFCjAgkg@jetpack YouTube HTML5 Switch v0.1.7 false jid0-coCUQ7NySNPcj72dA3557kKXGZU@jetpack

(Sorry for the weird formatting. I couldn't be bothered to fix the about:support extension list.)

bwinton commented 9 years ago

I think @mikeconley fixed this in product… Mike, can you confirm and close?

mikeconley commented 9 years ago

Things seem to work alright for me, but can either @strugee or @mozkeeler confirm as well?

mozkeeler commented 9 years ago

Looks like it's working for me - thanks!