search

bwinton / whimsy

An addon to add some whimsperiments to your Firefox…
64 stars 59 forks source link

newtab page shouldn't steal focus from URL bar #158

Closed Manishearth closed 7 years ago

Manishearth commented 7 years ago

Even with the improved newtab page disabled, Ctrl-T gives me a tab with focus on the DuckDuckGo search.

I like DDG, but typing in the DDG search doesn't give me URL suggestions, which is what I usually do on Ctrl-T. Can we have the ability to disable the newtab page completely or remove focus from the searchbox?

bwinton commented 7 years ago

Which OS/Version of Firefox? I only ever get the urlbar focused when I open a new tab…

Manishearth commented 7 years ago

Nightly, OSX.

This seems fixed now.

Manishearth commented 7 years ago

Or, no, it's happening again. If my cursor is already on the URL bar it works fine, but if it's e.g. typing in a github issue, and I Ctrl-T, the cursor moves to the DDG bar instead of the URL bar.

strugee commented 7 years ago

I can also reproduce this. Cmd-L also does not work, which makes this doubly-painful.

bwinton commented 7 years ago

Hmm. I still can't reproduce either of these behaviours on today's Nightly (57.0a1, 2017-08-08 64-bit) on macOS 10.12.6. Is there anything in the Browser Console, and can you reproduce them in a new, clean profile?

strugee commented 7 years ago

I'm on the 2017-08-11 Nightly and I see different behavior now... looks like neither the search box nor the URL bar are focused now?

bwinton commented 7 years ago

At this point, I'm convinced it's a Firefox bug, since WebExtensions have no way to focus or not focus the urlbar. Please file a bug over here, and hopefully it'll get fixed by one of the front-end developers.

strugee commented 7 years ago

Will do, thanks very much @bwinton!