search

bwmarrin / dgvoice

Discordgo Voice - A sub project to work on voice implementation for Discordgo
BSD 3-Clause "New" or "Revised" License
102 stars 39 forks source link

Return a optional PID #18

Closed felixfong227 closed 3 years ago

felixfong227 commented 4 years ago

I updated the functionPlayAudioFile and added a new optional argument that returns the ffmpeg PID.

In my personal application that I really needed the PID to kill the running process, since it will disrupt the audio flow.

I am pretty new to Go, so please bear with me overall code quality 🙇

bwmarrin commented 3 years ago

This would change the existing API and I do not want to do that. This repo is almost meant to be more of an example on how to get going. I'd recommend making a fork of this and adding this change to your fork for your use.