search

bwp91 / homebridge-ewelink

Homebridge plugin to integrate eWeLink devices into HomeKit.
MIT License
384 stars 126 forks source link

[Fan] Change Rotation Speed from percentage to levels #534

Closed vadimpronin closed 6 months ago

vadimpronin commented 6 months ago

This PR changes units for Rotation Speed of a Fan from % to speed levels. Sonoff fans have only 3 speed settings presented as Roman numerals on the remote (I, II, III). Original implementation presented these levels as 33%, 66% and 99% in HAP. Changing them to 1, 2 and 3 seems more intuitive and inline with original sonoff design

fan_settings
fan_badge
bwp91 commented 6 months ago

Oh wow I did not even know this scale/functionality was available in HAP. Might look into changing my other plugins too!

Out of interest, if you are using the existing version of the plugin with % scales, then change git branch to your changes, does the scale automatically update in the home app? or does it require removing the accessory for it to be re-added with the new scales?

bwp91 commented 6 months ago

This is really cool, thank you

bwp91 commented 6 months ago

@vadimpronin I was hoping you could check something further for me. (I do not have an iFan myself)

Would you be able to confirm that it works in the Homebridge UI? ie - not displaying a % and also it sliding properly between 0 - 1 - 2 - 3?

vadimpronin commented 6 months ago

Hey @bwp91

does the scale automatically update in the home app? or does it require removing the accessory for it to be re-added with the new scales?

The scale updates automatically after a few minutes

Would you be able to confirm that it works in the Homebridge UI? ie - not displaying a % and also it sliding properly between 0 - 1 - 2 - 3?

Being able to change the scale in the UI is cool! Will check it tomorrow!

swdwi2 commented 2 weeks ago

The main UI shows position 1, 2, 3 while the detail UI shows 1%, 2%, 3% IMG_3844A89188D5-1 IMG_A2D037ECD4AF-1 Appreciate any assistance you can give.

HomeBridge Installed: v1.8.2 HomeBridge UI Installed: v4.56.2 eWelink Plugin v12.2.0

vadimpronin commented 2 weeks ago

Can you try deleting and re-adding the accessory in the Home app?

swdwi2 commented 2 weeks ago

I did that. Also deleted and re added the bridge in HomeKit. No change unfortunately

Regards Dave

From: Vadim Pronin @.> Sent: Friday, June 14, 2024 2:16:45 AM To: bwp91/homebridge-ewelink @.> Cc: swdwi2 @.>; Comment @.> Subject: Re: [bwp91/homebridge-ewelink] [Fan] Change Rotation Speed from percentage to levels (PR #534)

Can you try deleting and re-adding the accessory in the Home app?

— Reply to this email directly, view it on GitHubhttps://github.com/bwp91/homebridge-ewelink/pull/534#issuecomment-2167608174, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALY4IS66BR3FNDKMIMTQL3DZHKYH3AVCNFSM6AAAAABJEXULP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRXGYYDQMJXGQ. You are receiving this because you commented.Message ID: @.***>