search

bwp91 / homebridge-meross

Homebridge plugin to integrate Meross devices into HomeKit.
MIT License
199 stars 32 forks source link

Load domain from config #507

Closed filipef101 closed 1 year ago

filipef101 commented 1 year ago

No idea how nobody complained about this before

First time contribution to an homebridge plugin, so not familiar with how UI for config is shown. I didn't see the UI updated after installing my fork, showing the domain input, but maybe the frontend fetches the UI from npm? I does default to io.meross.com so nothing should be broken? - would be good to double check as not sure if existing users will get the default domain inserted in their config, or if default keys are only when adding plugins. Happy to also fallback to the the js side.

Feel free to change anything on the PR to merge it 👍

filipef101 commented 1 year ago

@bwp91 The homeassistant addon for example does allow/make the user input an endpoint. Without this I could not login as my endpoint is iotx-eu.meross.com

filipef101 commented 1 year ago

Probably documentation updates should also be included

bwp91 commented 1 year ago

out of interest what is your error message from the plugin when you try to use it?

bwp91 commented 1 year ago

i made a couple of changes just to suit the plugin better, please let me know if you are still happy with the current state of the PR and i can merge it in

filipef101 commented 1 year ago

Shouldn't the default option be present? Otherwise I think the docs really should mention that the domain needs to be filled and

filipef101 commented 1 year ago

And will likely break the plugin for existing users @bwp91 no?