bwplotka / bingo

Like `go get` but for Go tools! CI Automating versioning of Go binaries in a nested, isolated Go modules.
Apache License 2.0
351 stars 29 forks source link

Install fail with Go 1.15.9: mvdan.cc/sh/v3/interp/api.go:313:10: undefined: io.Discard #102

Open mbideau opened 2 years ago

mbideau commented 2 years ago

go version output:

❯ go version
go version go1.15.9 linux/amd64

What happened: installation failed

What you expected to happen: installation succeed

How to reproduce it (as minimally and precisely as possible):

❯ (cd $(mktemp -d) && pwd && go get github.com/bwplotka/bingo)
/tmp/tmp.lsIlWXNRQs
# mvdan.cc/sh/v3/interp
/home/michael/go/src/mvdan.cc/sh/v3/interp/api.go:313:10: undefined: io.Discard
/home/michael/go/src/mvdan.cc/sh/v3/interp/api.go:317:10: undefined: io.Discard

Same with go install github.com/bwplotka/bingo

But it worked with :

❯ (cd $(mktemp -d) && pwd && go mod init _ && go get github.com/bwplotka/bingo)
/tmp/tmp.cVwENdlVBh
go: creating new go.mod: module _
go: downloading github.com/bwplotka/bingo v0.5.1
go: github.com/bwplotka/bingo upgrade => v0.5.1
go: downloading github.com/efficientgo/tools/core v0.0.0-20210201220623-8118984754c2
go: downloading github.com/Masterminds/semver v1.5.0
go: downloading github.com/pkg/errors v0.9.1
go: downloading mvdan.cc/sh/v3 v3.2.4
go: downloading github.com/oklog/run v1.1.0
go: downloading golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898
go: downloading golang.org/x/sys v0.0.0-20201029080932-201ba4db2418
go: downloading golang.org/x/term v0.0.0-20191110171634-ad39bd3f0407
❯ ll $(go env GOPATH)/bin/bingo
-rwxr-xr-x 1 michael michael 4,8M 11 nov.  18:40 /home/michael/go/bin/bingo

Anything else we need to know:

I tried to clean up and start from a fresh GOPATH: same result (with the GOPATH method).

Thanks in advance for making this program, I hope I would save me a lot of pain managing tools modules.