bwplotka / bingo

Like `go get` but for Go tools! CI Automating versioning of Go binaries in a nested, isolated Go modules.
Apache License 2.0
342 stars 29 forks source link

Add support for short module names #108

Closed nacx closed 2 years ago

nacx commented 2 years ago

The current code assumes module names have 3 or more path segments (typically github.com/org/module), but there are cases where custom module names may not follow that convention and be just domain/module. This is a small fix to support those modules as well.

nacx commented 2 years ago

@bwplotka Probably it is time also to change what are the required checks for the PR. Perhaps we can make Go 1.14 and 1.15 optional now and require 1.16 and 1.17?

nacx commented 2 years ago

@bwplotka ping?

nacx commented 2 years ago

bwplotka commented 2 years ago

Hah, sorry - ping me on Slack / Twitter next time - I don't follow GH notifications

nacx commented 2 years ago

Thx!