search

bwplotka / bingo

Like `go get` but for Go tools! CI Automating versioning of Go binaries in a nested, isolated Go modules.
Apache License 2.0
342 stars 29 forks source link

change to cobra, Improved code #121

Closed aimuz closed 1 year ago

aimuz commented 1 year ago

Signed-off-by: aimuz mr.imuz@gmail.com

bwplotka commented 1 year ago

Thanks for this contribution! Unfortunately, I can't accept it. I don't see a reason for changing the framework, plus the same "code improvements" can be done with the existing framework we are familiar with (even though it's not supported anymore).

Next time, please make sure to discuss such idea before submitting the code. Plus some description on why it should be merge would be nice! 🤗 Thanks! Closing for now, happy to reopen if you disagree with me.

aimuz commented 1 year ago

I think the existing command prompt is too confusing, it may be clear for the maintainer, but for the user, he needs a good command prompt. The refactoring will make it simpler to use and I think it will be easier for contributors to understand in terms of code

bwplotka commented 1 year ago

Do you mind rebasing?

aimuz commented 1 year ago

Fixed

bwplotka commented 1 year ago

Thanks for fixing tests - approval for CI is annoying - we will get rid of this once you submit your first contribution 💪🏽 Thanks for patience!