search

bwplotka / bingo

Like `go get` but for Go tools! CI Automating versioning of Go binaries in a nested, isolated Go modules.
Apache License 2.0
342 stars 29 forks source link

Fix ./bingo/README.md: variables.go was never supported. #141

Closed kishaningithub closed 7 months ago

kishaningithub commented 1 year ago

bingo version output: v0.8

go version output: go version go1.20.4 darwin/arm64

What happened: variables.go file is not generated by bingo as documented in README

What you expected to happen: variables.go should be generated

How to reproduce it (as minimally and precisely as possible):

Examples: You can see it in this repo itself. If you look at the code below you see the README documentation generated by bingo https://github.com/bwplotka/bingo/blob/fd11be5060a91cd566699904a8a58aa9973c00f6/.bingo/README.md?plain=1#L9 but if you look at the directory the variables.go file is not present.

aimuz commented 1 year ago

This does not seem to be supported

bwplotka commented 11 months ago

Thanks!

Sorry, it's left our readme item, it's not supported as we didn't find a lot of use cases. Do you need this?

Let's then remove the mention of it - here: https://github.com/bwplotka/bingo/blob/main/get.go#L820

Help wanted (:

kishaningithub commented 11 months ago

@bwplotka I was hoping that this would fix the following observation (screenshot and link below)

https://github.com/jeroenrinzema/psql-wire/pull/58#discussion_r1198710199

image