Irrigation type to be known as Others

bwssytems / domuslink

web-based frontend for Heyu

http://domus.link.co.pt/

1 stars 1 forks source link

Irrigation type to be known as Others #12

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Purpose of feature on this branch:
Change type tab Irrigation to be Others. This will be more flexible when
adding new module types.

Proposition for feature implementation:
Change text labels from Irrigation to Others.
Create new image files for tab for Others.

When reviewing my code changes, please focus on:
layout.tpl

After the review, I'll merge this branch into:
/prev11

Original issue reported on code.google.com by bwsamuels@gmail.com on 6 Mar 2010 at 5:24

GoogleCodeExporter commented 9 years ago

I don't agree with this. Some home automation software organize by room, but 
this one
organizes by system. Lighting system, appliances system (maybe merge lighting 
and
appliances), irrigation system, security system (soon i hope), speech system 
(pipe
dream for now), etc... I say we make these systems modular and 'bolt-on' ready.

Original comment by brandtda...@gmail.com on 7 Mar 2010 at 2:48

GoogleCodeExporter commented 9 years ago

I would agree as well. But this is a small change to the system to make it more
understandable when other module types are added. I a had a post somewhere on 
one of
the group lists mentioning that these tabs should all be configurable. I just 
don't
think we will get that done for the v1.1 release.

Original comment by bwsamuels@gmail.com on 7 Mar 2010 at 3:20

GoogleCodeExporter commented 9 years ago

I'm wondering if this should be an addition now. We have shutters and 
irrigation. It
would be easier to add another tab to be others. After seing the shutter impl I
believe this is a better alternative.

Original comment by bwsamuels@gmail.com on 27 Mar 2010 at 12:46

GoogleCodeExporter commented 9 years ago

Original comment by bwsamuels@gmail.com on 27 Mar 2010 at 7:13

Changed state: Started

GoogleCodeExporter commented 9 years ago

This issue was closed by revision r647.

Original comment by bwsamuels@gmail.com on 27 Mar 2010 at 7:44

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

I dont really understand the 'button' for Other. The green and the red 
(powerplugs?)
never get grayed out like everything else when the item is off. Also, you would 
think
that green means go (on), and red means stop (off) but they never change their 
open
and closed states.

I dunno I just find it confusing as to what it visually represents.

Original comment by brandtda...@gmail.com on 9 Apr 2010 at 4:55

GoogleCodeExporter commented 9 years ago

I just picked some icons that would represent on (green) and off (red) without
displaying status. The status of the module is represented by the highlight (or 
not)
of the icon in the upper left. Trying to make it pretty generic.

Original comment by bwsamuels@gmail.com on 10 Apr 2010 at 3:31

GoogleCodeExporter commented 9 years ago

Can we at least may grayscale copies of the icons so when the module is off the 
icons
are grayed out, that seems to be the norm in dL.

Original comment by brandtda...@gmail.com on 10 Apr 2010 at 11:37

GoogleCodeExporter commented 9 years ago

The buttons are to be active all the time. They are not tied to state in this 
module.
I agree it looks confusing as I have many "other" modules in my setup and it 
looks
like Christmas. I'll look for different icons. I was hoping to find a power "1" 
and
"0" icon to use but haven't found one.

Original comment by bwsamuels@gmail.com on 11 Apr 2010 at 1:59