bwssytems / domuslink

web-based frontend for Heyu
http://domus.link.co.pt/
1 stars 1 forks source link

gui does not validate timer ranges #73

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. adjust timers with security and dusk
   (via the gui)

2.
added via the gui the following timer in the schedule file:

timer smtwtfs 01/01-12/31 dusk+100s dusk+340s outside_lamps_on outside_lamps_off

3.

What is the expected output? What do you see instead?

expected output is that timers are still working and can be uploaded.
but the problem reported by the upload command is:

Exec: heyu upload
exception 'Exception' with message 'Line 39: Expanded timer[48] stop time 1450 
falls outside range 0-1439' in /var/www/domus.Link/lib/func/cmd.func.php:283 
Stack trace: #0 /var/www/domus.Link/events/upload.php(54): heyu_upload() #1 
{main}

expected that the input gui has check for timer functions.
changing the 

What version of Heyu and domus.Link are you using? On what operating
system?

latest version

Please provide any additional information below.

Original issue reported on code.google.com by ControlM...@gmail.com on 30 Aug 2011 at 8:24

GoogleCodeExporter commented 9 years ago
changing the value to 

timer smtwtfs 01/01-12/31 dusk+100s dusk+245s outside_lamps_on outside_lamps_off

works, need to check the timer setting but expected that the gui validation has 
been done on this before uploading the data to the cm11

Original comment by ControlM...@gmail.com on 30 Aug 2011 at 8:53

GoogleCodeExporter commented 9 years ago
Interesting, will need to add that check as I didn't know that could happen. 
Will try to include some more checks in the next release.

Original comment by bwsamuels@gmail.com on 7 Sep 2011 at 12:38

GoogleCodeExporter commented 9 years ago
So, the only way to do this validation is to pick an earliest dusk time to 
validate against. The line you show above is 5.6 hours after dusk which must 
cross the 23:59 hour boundary that heyu determines is it's maximum.

My first inclination is to do a better job reporting the error back to the GUI 
from heyu and not add in calculations on a moving target that we would have to 
calculate.

Original comment by bwsamuels@gmail.com on 4 Dec 2011 at 3:59

GoogleCodeExporter commented 9 years ago
Build validation for heyu error reporting.

Original comment by bwsamuels@gmail.com on 7 Dec 2011 at 2:43

GoogleCodeExporter commented 9 years ago
sorry for my late response.
let me try the newer version and see the "enhanced" error reporting.

Original comment by ControlM...@gmail.com on 8 Dec 2011 at 10:16

GoogleCodeExporter commented 9 years ago
I don't have a date yet for the rollout of this update. It is not in v2.0.1 but 
slated for the next one.

Original comment by bwsamuels@gmail.com on 8 Dec 2011 at 2:09

GoogleCodeExporter commented 9 years ago
After reviewing what is needed to do, I have decided to let the exception error 
message be the validation. It will be very complicated to do a verification 
check in domus.Link and heyu does do it on the upload.

Original comment by bwsamuels@gmail.com on 19 Feb 2012 at 5:08