search

bwssytems / ha-bridge

Home automation bridge that emulates a Philips Hue light system and can control other systems such as a Vera, Harmony Hub, Nest, MiLight bulbs or any other system that has an http/https/tcp/udp interface. This is a compact impl to run on small format computers. This is impl started from this project https://github.com/armzilla/amazon-echo-ha-bridge.
Apache License 2.0
1.45k stars 199 forks source link

Should new devices be given 9-octet IDs by default? #1384

Open marcosscriven opened 1 year ago

marcosscriven commented 1 year ago

Thanks for your efforts on this project - really nice to be able to integrate with Alexa without fiddling with adding skills.

It took me a while to get this going with a simple test http device - eventually it seems the device ID has to:

  1. Have no hyphen in (see https://github.com/bwssytems/ha-bridge/issues/1272#issuecomment-748689997)
  2. Have 9 octets (see https://github.com/bwssytems/ha-bridge/issues/1270#issuecomment-812894624)

Mine was of the form nn:nn:nn:nn:nn:nn:nn-nn. Initially I just tried changing the hyphen to a colon, but still no devices discovered , despite ./api/devices looking fine, and seeing all the expected UPnP trace logs.

I'm happy to update the wiki /trouble shooting (at the very least) to mention this, so people don't get too frustrated.

I'd also be interested in fixing the code to just generate the right form to start with - but only if you agree that's as expected?

marcosscriven commented 1 year ago

Digging in I see @crush157's commit adding this as an option https://github.com/bwssytems/ha-bridge/pull/1358/commits/7f72b0311a3d21780fa27e168da6824861f0b706

However, I don't see any discussion or background on the PR.

Should this now be set to true by default?

guy1958 commented 1 year ago

Yes, I'd check that box by default.