bwsw / cloudstack-ui

Modern UI for Apache Cloudstack User Self Service Portal
https://bitworks.software/
Apache License 2.0
164 stars 63 forks source link

Pulse - Remove restriction of "100" for shift #1559

Closed Nadya913 closed 5 years ago

Nadya913 commented 5 years ago

Description

Actual result

Shift buttons are inside the chart, "100" is a max number if enter by increase button

Expected result

  1. Shift buttons are outside the chart if no data appears in chart
  2. The only restriction for "shift" is non negative integer value

    Screenshots

    shift.png

Connected requirements:

REQ_PLS_005, REQ_PLS_010, REQ_PLS_015

bwsw commented 5 years ago

Not a bug. Lack of stats.

Nadya913 commented 5 years ago

Not a bug. Lack of stats.

Ok, just needed to fix the layout of the shift button in charts.

bwsw commented 5 years ago

@Nadya913 I don't get what to fix. It's normal if no stats. The system shouldn't care about that.

Nadya913 commented 5 years ago

@bwsw @bwsw-Andrey-Andreev The shift value input has the restriction in UI as maximum 100, the value more than 100 can't be set by increase button. But you can input the value more than 100 by the keyboard. Also, the visible size is for 5 digits. max

Question: what the restriction we have for shift value?

elenaustyugova commented 5 years ago

@bwsw Please see the comment above. What is preferable?

elenaustyugova commented 5 years ago

@Nadya913 @bwsw-Andrey-Andreev @evgeniiamokhova @nikonov1996 discussed with PO: remove the constraint of 100 for the shift, a user should be able to enter any non negative integer value

dron8552 commented 5 years ago

TO TEST: REQ_PLS_005, REQ_PLS_010, REQ_PLS_015

evgeniiamokhova commented 5 years ago

Lack: 1

1) System don't ignore symbols in input field Shift after attempt enter of not integer value

Actual result: When enter plus and number(s)(+9)/number(s) and point(8.)/number(s) and comma(9,) system don't ignore symbols Expected result: When enter numbers and symbol in input, system ignore point/comma/plus and leave only numbers according to exception in REQ_PLS_005, REQ_PLS_010, REQ_PLS_015

3) Values differ in tabs in Shift when replacing an invalid value

After entered negative number/space in input system changed value on 0, but negative value/space is saved on other tabs

Actual result: When enter negative number/space in input system change value on 0, but negative value/space is saved on other tabs Expected result: When enter negative number/space in input system change value on 0, values on all tabs should be the same according to REQ_PLS_005, REQ_PLS_010, REQ_PLS_015 2019-02-18 08-06-03 2019-02-18 08-06-12

dron8552 commented 5 years ago

Fixed. It should work like Session timeout input in the Settings. But if this behavior isn't correct, create a separate ticket, please.