search

bwsw / cloudstack-ui

Modern UI for Apache Cloudstack User Self Service Portal
https://bitworks.software/
Apache License 2.0
163 stars 63 forks source link

Add billing hook notifications to UI #1602

Closed elenaustyugova closed 5 years ago

elenaustyugova commented 5 years ago

Description

User should be able to see readable error messages/notifications when updating resources

This issue covers the following requirements:

REQ_RSC_001

elenaustyugova commented 5 years ago

To test: 3 test cases mentioned in Requirements 1.411.29 doc

dron8552 commented 5 years ago

Test on PR using Netpoint users with domains.

Nadya913 commented 5 years ago

@bwsw Ivan, we have 3 cases to discuss:

  1. Error text contains not requested amount resources (DATABOX).
    • Case RAM: The current amount limit of Ram is 4 GB and min quota is 2 GB. According to the error was requested 6 GB, but it wasn't - please see the video. Expected: 4 GB peek 2019-02-28 16-15
    • Case Primary: The current amount limit of Primary is 1100 GB and min quota is 1000 GB. According to the error was requested 1000 GB, but it wasn't - please see the video. Expected: 1100 GB peek 2019-02-28 16-26
  2. Calculated balance from billing appear as not currency value: The requested resources RAM: 11 GB, Primary Storage: 100 GB, Secondary Storage: 1542 GB cannot be provided. Automatic allocation requires that the account balance is not less than 1349.6000000000001 Rub., current balance is 762.18 Rub. / Запрошенные ресурсы ОЗУ: 117 ГБ, Основное хранилище: 70 ГБ, Дополнительное хранилище: 276 GB не могут быть предоставлены. Для автоматического выделения требуется чтобы баланс счета был не менее чем 5670.490000000001 Руб., сейчас 761.11 Руб.
elenaustyugova commented 5 years ago

@Nadya913 2nd fail is fixed by Ivan

dron8552 commented 5 years ago

Fixed multiple requests when updated resources by the user and admin (send all changed resources in one request).

elenaustyugova commented 5 years ago

@Nadya913 also please test

Nadya913 commented 5 years ago
  1. The setting quota is broken for zero value both for min and max. The quota parameter isn't sent in this case. http://cs-ui-ci.bitworks.software:8888/1604/client/api?command=gatewayApi&cmd=updateResourceLimits&maximum2=15&realm=resource-limits&env=cs2-development&response=json&sessionKey=wdyv_ViP9_DoYg-46KMpx1FDvzU Expected: The quota parameter with zero value is sent. zero
  2. 5 digit number is cut in value slider. This is a master bug, but would you please fix it if possible here. 5digit
  3. @bwsw The current amount limit of Primary is 1100 GB and min quota is 1000 GB in databox domain. According to the error was requested 1000 GB, but it wasn't - please see the video. Expected: 1100 GB in text error should appear testprimary
dron8552 commented 5 years ago

Fixed except the third point.

Nadya913 commented 5 years ago

The first and second issues are fixed. Waiting for feedback for third issue.

elenaustyugova commented 5 years ago

@Nadya913 third issue was fixed by Ivan. let's check it and if there are no other cases for regression - please resolve the issue

Nadya913 commented 5 years ago
  1. Request resource button isn't aligned with free/user switcher in Firefox. requestbutton