Closed huadream closed 4 years ago
Can one of the admins verify this patch?
We think that it will be better to constantly use 'Search...' for the search box placeholder. It is intuitive that the search will be for the current context.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/app/shared/components/notification-box/notification-box.component.ts | 1 | 2 | 50.0% | ||
src/app/vm/container/vm-filter.container.ts | 1 | 6 | 16.67% | ||
src/app/template/containers/template-filter.container.ts | 2 | 8 | 25.0% | ||
src/app/shared/components/sidebar/sidebar-container/sidebar-container.component.ts | 4 | 11 | 36.36% | ||
src/app/snapshot/snapshots-page/snapshot-filter/snapshot-filter.container.ts | 2 | 13 | 15.38% | ||
src/app/core/services/navbar.service.ts | 7 | 43 | 16.28% | ||
<!-- | Total: | 17 | 83 | 20.48% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/app/template/template-filters/template-filters.component.ts | 1 | 67.8% | ||
src/app/shared/components/sidebar/sidebar-container/sidebar-container.component.ts | 2 | 34.09% | ||
<!-- | Total: | 3 | --> |
Totals | |
---|---|
Change from base Build 1824: | -0.2% |
Covered Lines: | 9535 |
Relevant Lines: | 15891 |
I didn't add some translations for Russian because I don't know Russian. There is also something to do for mobile devices layout.
desktop![image](https://user-images.githubusercontent.com/16542723/61065503-61f2c480-a436-11e9-8d88-e9bfd81c76b8.png)
tablets
![image](https://user-images.githubusercontent.com/16542723/61066353-f6115b80-a437-11e9-9518-4910efbd811a.png)
phone
![image](https://user-images.githubusercontent.com/16542723/61066306-daa65080-a437-11e9-928e-809299be62cf.png)
other instructions https://github.com/bwsw/cloudstack-ui/pull/1668#issuecomment-509276400