bwsw / cloudstack-ui

Modern UI for Apache Cloudstack User Self Service Portal
https://bitworks.software/
Apache License 2.0
163 stars 63 forks source link

navbar & improve sidenav & responsive design #1672

Closed huadream closed 4 years ago

huadream commented 5 years ago

I didn't add some translations for Russian because I don't know Russian. There is also something to do for mobile devices layout.

desktop image

tablets image image

phone image image image

other instructions https://github.com/bwsw/cloudstack-ui/pull/1668#issuecomment-509276400

bw-ci commented 5 years ago

Can one of the admins verify this patch?

dron8552 commented 5 years ago

We think that it will be better to constantly use 'Search...' for the search box placeholder. It is intuitive that the search will be for the current context.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 1840


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/app/shared/components/notification-box/notification-box.component.ts 1 2 50.0%
src/app/vm/container/vm-filter.container.ts 1 6 16.67%
src/app/template/containers/template-filter.container.ts 2 8 25.0%
src/app/shared/components/sidebar/sidebar-container/sidebar-container.component.ts 4 11 36.36%
src/app/snapshot/snapshots-page/snapshot-filter/snapshot-filter.container.ts 2 13 15.38%
src/app/core/services/navbar.service.ts 7 43 16.28%
<!-- Total: 17 83 20.48% -->
Files with Coverage Reduction New Missed Lines %
src/app/template/template-filters/template-filters.component.ts 1 67.8%
src/app/shared/components/sidebar/sidebar-container/sidebar-container.component.ts 2 34.09%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 1824: -0.2%
Covered Lines: 9535
Relevant Lines: 15891

💛 - Coveralls