search

bwu-dart / bwu_datagrid

A data-grid Polymer element in Dart
MIT License
73 stars 26 forks source link

Support for several datagrids on the same page #112

Open gonzalopezzi opened 9 years ago

gonzalopezzi commented 9 years ago

I have added some extra css classes to support multiple datagrids on the same page, in Firefox and Internet Explorer The id of the bwu-datagrid tag is added as a class in some elements. If no id is provided, the component generates a new id automatically.

zoechi commented 8 years ago

Sorry for not responding earlier. I wanted to investigate if this is necessary in Polymer 1 or how it would be implemented there (as usual everything takes much longer than anticipated), but I guess the old Polymer version will live for a while longer anyway.

I added a few suggestions. I would leave the provided id attribute alone, it could get out of sync easily anyway because attribute values could be changed at any time.

Please give me a note if you plan to make the changes, otherwise I'll just merge your PR and make the additional changes myself.

gonzalopezzi commented 8 years ago

Thanks Zeochi. It was fun to try to fix this. I completely agree with your comments. I am very busy right now, so I would appreciate it if you could merge my code and make those changes.

Btw, can't wait to start using bwu_datagrid for Polymer 1.0! Good luck! ;)

zoechi commented 8 years ago

Great, will do. Thanks a lot for the quick feedback!

zoechi commented 8 years ago

fix for #107