Question: Should we use a pointer as a return type of NewUsecase, NewRepository?

[aeharvlee]

In this repo, there are building functios like below(NewUsecase or NewRepository)

type mysqlArticleRepository struct {
    Conn *sql.DB
}

// NewMysqlArticleRepository will create an object that represent the article.Repository interface
func NewMysqlArticleRepository(Conn *sql.DB) domain.ArticleRepository {
    return &mysqlArticleRepository{Conn}
}

As you can see, it returns address using &mysqlArticleRepository which of data type is a pointer. So I think return type should be pointer *domain.ArticleRepository like below

type mysqlArticleRepository struct {
    Conn *sql.DB
}

// NewMysqlArticleRepository will create an object that represent the article.Repository interface
func NewMysqlArticleRepository(Conn *sql.DB) *domain.ArticleRepository {
    return &mysqlArticleRepository{Conn}
}

I want to hear what you guys think about this. Thanks for reading this issue. 😄

[ghostiam]

domain.ArticleRepository is interface, interface cannot be pointer.

[aeharvlee]

@ghostiam Thanks for your feedback. 👍

[frederikhors]

I think you can close this issue now.