search

bxlab / bx-python

Tools for manipulating biological data, particularly multiple sequence alignments
MIT License
145 stars 53 forks source link

From NumPy 1.24.0 ``np.float`` is deprecated #90

Closed lldelisle closed 1 year ago

lldelisle commented 1 year ago

I removed them to make bx-python compatible with last version of numpy but this drop support for numpy <1.20. I don't know which file I should modify.

lldelisle commented 1 year ago

@nsoranzo do you know where should I restrict numpy version?

nsoranzo commented 1 year ago

I removed them to make bx-python compatible with last version of numpy but this drop support for numpy <0.20

Are you sure this breaks compatibility with older numpy? And, do you mean numpy <1.20 perhaps?

lldelisle commented 1 year ago

Yes exactly The new code requires numpy>=1.20

nsoranzo commented 1 year ago

It does seem to work in my hands as far back as numpy 1.14.5 , what error do you see?

lldelisle commented 1 year ago

Then perfect. I thought these changes would break... One deploy was too long, is it ok to merge like this?

nsoranzo commented 1 year ago

Yes, thanks, will fix the deploy separately.

nsoranzo commented 1 year ago

Yes, thanks, will fix the deploy separately.

Fixed in https://github.com/bxlab/bx-python/commit/6f7e5ca3d9b4801afb2de5452a93feee5a7cedd7 . Let me know if we should do a release.

lldelisle commented 1 year ago

For me it is ok. Let see if people need it.