search

by-implication / Open-Reconstruction

Issue tracking + project proposal system, built for DBM + World Bank —
http://openreconstruction.gov.ph
ISC License
6 stars 3 forks source link

When the request list is scrolled down a bit, going to a specific request is also scrolled #142

Closed ahelpingchip closed 10 years ago

ahelpingchip commented 10 years ago

(not that big a deal tho, I guess.)

livtanong commented 10 years ago

That's actually the case no matter the view. On any page (page A), if you scroll and click on a link. the page it goes to, provided it is scrollable, will be scrolled to the position you were in at page A.

The fix for this will probably be a line in the app template controller coercing the scrollTop to be 0 every time, though not sure if want.

ghost commented 10 years ago

this is a bug in mithril routing if anything, and i'm currently putting a fix in and will later on submit it as a pull request

ghost commented 10 years ago

question @ahelpingchip @levitanong

i have a temporary fix, but a side-effect is that switching page or filtering triggers scrolling back up to the top. is this desired behavior y/n?

livtanong commented 10 years ago

switching page, yes. filtering, no.

ghost commented 10 years ago

fyi, filtering resets the page to 1 so maybe also yes?

ghost commented 10 years ago

or is it more because of the accessibility of the controls in the layout? :/

livtanong commented 10 years ago

what do you mean by accessibility?

ghost commented 10 years ago

the page controls are easily clickable even after a scroll reset. the filters, not necessarily.

livtanong commented 10 years ago

Well yeah. That's my main concern, but Fuck it. Do it na :))

ghost commented 10 years ago

https://github.com/by-implication/Open-Reconstruction/commit/63e011348de11b36187fddc9032385bc11552092