search

by-pinja / ng-virtual-keyboard

Virtual Keyboard for Angular applications
https://protacon.github.io/ng-virtual-keyboard/
MIT License
25 stars 43 forks source link

Implementation feture type with tag ng-virtual-keyboard-type #26

Closed gabrielbo1 closed 5 years ago

gabrielbo1 commented 5 years ago
Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #11
License MIT

Support password input types 

     <input name="senha" type="password" placeholder="Password"
         [(ngModel)]="passowrdVariable" maxlength="32"
         ng-virtual-keyboard
         ng-virtual-keyboard-layout="alphanumeric"
         ng-virtual-keyboard-type="password" />
tarlepp commented 5 years ago

missing example on demo app, see #11

gabrielbo1 commented 5 years ago

missing example on demo app, see #11

Pull request desciprtion updated with usage example

tarlepp commented 5 years ago

sorry but that isn't enough - users should be able to try this out on https://protacon.github.io/ng-virtual-keyboard/ - that is why asked you to add that example to that demo app.

gabrielbo1 commented 5 years ago

sorry but that isn't enough - users should be able to try this out on https://protacon.github.io/ng-virtual-keyboard/ - that is why asked you to add that example to that demo app.

Ok, I changed the component so that everything works, we must commit and push the dist folder

tarlepp commented 5 years ago

I'm trying to check this out closer next week - but no promises. Anyone @protacon/employees could also take a closer look.

gabrielbo1 commented 5 years ago

Hello, I would like to have my merge request accepted because we are depending on this library to launch a project of the company where I work, and would like to import the same using npm, my change was very simple and I believe that we will not have problems. I thank you for your attention.

Hekku2 commented 5 years ago

Hi, sorry for the delay, I'll talk about this tomorrow at our meeting. I'm not personally familiar with this project so I'd rather find someone who is.

Hekku2 commented 5 years ago

I'll try to publish new version later today or tomorrow.

gabrielbo1 commented 5 years ago

OK thanks.

tarlepp commented 5 years ago

new version released to npmjs - although I'm thinking about if input is password should that actual input to be shown user itself? at least we should add user to choose if he/she want to see that input password or not.

Allthough not sure if examples are updated correctly because I'm not seeing that password input there atm - or I might be forgetting some stuff - will take a closer look tomorrow - hopefully

gabrielbo1 commented 5 years ago

Well I looked at the demo and it was not correct in the demo. I do not know if I would have to run a specific build for the demo to work. In the company where I work the feature is working properly. Thanks!!! =)