by-pinja / ng-virtual-keyboard

Virtual Keyboard for Angular applications
https://protacon.github.io/ng-virtual-keyboard/
MIT License
25 stars 43 forks source link

Add base for dockerfile #50

Closed Hekku2 closed 3 years ago

Hekku2 commented 3 years ago

Add docker file so this project can be compiled without having to install more stuff locally (this is done in preparation so I can verify those library updates etc.)

Also:

tarlepp commented 3 years ago

Nope there should be just one of those

ke 4. elok. 2021 klo 11.11 Heikki-Jussi Niemi @.***> kirjoitti:

@.**** commented on this pull request.

In package.json https://github.com/by-pinja/ng-virtual-keyboard/pull/50#discussion_r682390365 :

@@ -51,9 +51,9 @@ "codelyzer": "^2.0.1", "core-js": "^2.4.1", "css-loader": "^0.28.0",

  • "extract-text-webpack-plugin": "^2.1.0",
  • "node-sass": "^4.5.2",
  • "npm-run-all": "^4.0.2",
  • "extract-text-webpack-plugin": "^2.1.2",
  • "node-sass": "4.12.0",
  • "npm-run-all": "4.1.5",

Good point.

BTW, do we have a need for both, package-lock.json and yarn.lock in this project?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/by-pinja/ng-virtual-keyboard/pull/50#discussion_r682390365, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAERM2PIZXQ44XJSIRO2YR3T3DY4LANCNFSM5BOTYX4A .

Hekku2 commented 3 years ago

Okay, I'll choose yarn.lock then.