byCedric / semantic-release-expo

An Expo implementation for semantic release, so you don't have to bother.
MIT License
91 stars 11 forks source link

Update library for usage with new manifest format #175

Open byCedric opened 4 years ago

byCedric commented 4 years ago

Description of the feature

Evan is working on some changes related to the manifest format. If this is merged and supported, we need to update this library. It's still pending review, but once it's merged I'll start on it 😄

Motivation

Everything Expo supports, we should implement. 🚀

owentar commented 4 years ago

Hi guys! Seems like part of those changes mentioned above went through into Expo's SDK 37. They basically removed the sdkVersion from the app.json file. Are we planning to put an update for this?

WORK AROUND: add back in the sdkVersion.

owentar commented 4 years ago

Looking at how to implement this since the sdkVersion is no longer in the app.json. Can we relay on expo-constants as a dependency to get this value (from NativeConstants.manifest.sdkVersion)?