search

byashimov / django-controlcenter

Set of widgets to build dashboards for Django projects
BSD 3-Clause "New" or "Revised" License
989 stars 85 forks source link

show sorting triangles #41

Closed minusf closed 5 years ago

minusf commented 5 years ago

My users find the sorting gradient a bit too subtle, I think the triangles make it much easier to see what's going on. CSS taken from sortable's minimal css.

codecov-io commented 5 years ago

Codecov Report

Merging #41 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop    #41   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files            9      9           
  Lines          401    401           
======================================
  Hits           401    401

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b4d0f6a...775fcd1. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #41 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop    #41   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files            9      9           
  Lines          401    401           
======================================
  Hits           401    401

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b4d0f6a...775fcd1. Read the comment docs.

byashimov commented 5 years ago

Could you provide screenshots with changes (then, now). I have no chance to check this on my own.

minusf commented 5 years ago

no triangles:

screenshot 2019-01-21 at 13 20 18 screenshot 2019-01-21 at 13 20 26

triangles:

screenshot 2019-01-21 at 13 16 43 screenshot 2019-01-21 at 13 16 49
minusf commented 5 years ago

as you can see, all.css is getting the same changes from the grunt job as in my other PR. perhaps you can just accept the all.styl changes and generate all.css yourself?

byashimov commented 5 years ago

Thanks for a screenshot. Please, take a look at another request with dropped css style (subtitle class).

minusf commented 5 years ago

what would you like me to do? send just the all.styl change and you will generate and commit all.css?

$ node_modules/.bin/stylus  -V
0.54.5
$ node_modules/.bin/grunt  -V 
grunt-cli v1.2.0
grunt v1.0.3
byashimov commented 5 years ago

F*k. Sounds like changes was made in css directly (not in styl). So when you regenerate new css it drops unknown class. I will have to fix css after your merge.