search

bye-Tyrael / chromiumembedded

Automatically exported from code.google.com/p/chromiumembedded
0 stars 1 forks source link

Enhancement: Enable zoom support #116

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Patch to enable zoom in/out/normal

Original issue reported on code.google.com by lodle...@gmail.com on 5 Sep 2010 at 8:13

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by magreenb...@gmail.com on 6 Sep 2010 at 6:58

GoogleCodeExporter commented 9 years ago 
My patch for enabling zoom. Note the difference in the interface and the change 
in libcef/browser_webview_delegate.cc

Original comment by nesf...@gmail.com on 9 Sep 2010 at 8:01

Attachments:

GoogleCodeExporter commented 9 years ago 
I would like to support an interface similar to the View->Zoom menu in Firefox. 
It provides "Zoom In", "Zoom Out" and "Reset" items and a checkable "Zoom Text 
Only" item.  It also keeps the zoom state associated with each page.  So we can 
start with nesf's patch and make the following enhancements:

1. Add a "bool IsZoomTextOnly()" method.
2. Rename the SetZoomLevel method to SetZoom since it sets both the level and 
the text only status.
3. Store the zoom information in the history state so navigating to/from a page 
will restore the zoom to whatever value the user last used for that page.

Original comment by magreenb...@gmail.com on 23 Sep 2010 at 3:51

GoogleCodeExporter commented 9 years ago 
As far as I can see, the latest stable version of Chrome (8.0.552.237) no 
longer offers the feature of a text only zoom. Firefox, as of 3.6.13, still 
does.

According to the documentation for zoomLevel() and setZoomLevel() in WebView.h 
(http://www.google.com/codesearch/p?vert=chromium#OAMlx_jo-ck/src/third_party/We
bKit/WebKit/chromium/public/WebView.h&l=174), "Changing the mode while the page 
is zoomed will have odd effects."

Having a text only zoom might not be something that we want to pursue right 
now, seeing as how Chrome has already removed the feature.

Original comment by nesf...@gmail.com on 14 Jan 2011 at 7:54

GoogleCodeExporter commented 9 years ago 
Another draft of the zooming feature. The updated cefclient's zooming feature 
now behaves like Firefox 3.6.13.

Original comment by nesf...@gmail.com on 21 Jan 2011 at 7:13

Attachments:

GoogleCodeExporter commented 9 years ago 
Overall the patch in comment #5 looks good. A few minor nits:

1. Be careful about unnecessary changes when editing resources with Visual 
Studio (cefclient.rc, resource.h).
2. All files should end in a newline (browser_zoom_map.cc, browser_zoom_map.h).
3. The isZoomTextOnly_ variable should be named is_zoom_text_only_ in order to 
match the coding style. This is a moot point if text-only zoom support is 
removed.

Does anyone specifically need text-only zoom?  If not, let's drop it given that 
Chrome is no longer supporting it. This will also simplify the 
interface/implementation.

Original comment by magreenb...@gmail.com on 24 Jan 2011 at 9:48

GoogleCodeExporter commented 9 years ago 
Here's a draft that doesn't have text-only zoom. I also addressed the 
unnecessary changes in the VS resource files and the lack of newline in the new 
files.

Original comment by nesf...@gmail.com on 25 Jan 2011 at 1:38

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks for your work on this. Committed as revision 167 with the following 
changes:

1. Use the Singleton<> pattern for ZoomMap.
2. Pass GURL instead of CefString to the ZoomMap methods.

Original comment by magreenb...@gmail.com on 25 Jan 2011 at 3:36