Andreas/Dave/Jonas newpost newattachment [DONE]

afruth commented 9 years ago

@DaveSauce you can use this branch to work on the New Post window and push to it.

@Sanjo in this PR you also have the back-end code for the attachments type of message

@everyone Please help me with a bit of code review when you can

afruth commented 9 years ago

Ok @DaveSauce looking into it right now

afruth commented 9 years ago

@DaveSauce i've played a bit and what you are asking with "I've added a button (the 'A' in the bottom left), that I'd like to call the style plugin. This will make the fancy new editor easy for old school users." is not possible with the current editor. If those are important features i can look for another editor.

When nothing is selected, the editor doesn't work, even if it's showing it won't work. If you select something the editor appears automatically, and there's no point for the extra button to show it.

I've added a few extra buttons and removed the H's (i remember Robin asked if it's possible).

I'm trying now to move the images into the main toolbar, but it also looks difficult to pull off.

afruth commented 9 years ago

@DaveSauce @RobinBascom i can't force it to move the image and embed buttons into the main toolbar. Do we continue with this editor or do i start looking for another?

afruth commented 9 years ago

@DaveSauce Passing back to you. In football there are a lot of passes in the team. The team that passes the most wins, as opposed to handegg where theres usually one pass :football:

To dos:

Style the toolbar to stay wherever you want it. Also to start hidden if you want (i've added the option to toggle it on the little button in the corner)
Re-add the scrollbars. I had to remove them as the mCustomScrollBar adds a lot of custom html that bleeds into the final post. If you want to show the scrollbar maybe wrap the contenteditable in another div and put the scrollbar there?
The selectpicker looks weird
The contenteditable div doesn't resize properly
The images might have use of a max-width: 100% property so that they don't go outside boundaries (also when they are shown in posts).
When you click new image, the drop-down area might need a bit of styling
let me know what buttons to show in the toolbar

If you want me to take on any of the above let me know. Also pass back when you are done to wrap-up and get this ready for master :)

ghost commented 9 years ago

I've finished https://trello.com/c/oPfhmvwD/298-if-a-user-hits-message-menu-and-then-clicks-attachment-then-they-should-be-able-to-add-a-file-from-there-file-system-user-should in the branch https://github.com/GoOne/one/tree/jonas_attachment_message. The branch is based on andreas-newpost-newattachment.

Should I merge my branch just into this one or should I wait until this branch has been merged to master? I ask because this branch has "newattachment" in the name.

DaveSauce commented 9 years ago

@afruth I love soccer!! :wink:

This looks great - I'll get going on it today.

afruth commented 9 years ago

@Sanjo i think it's best to merge your branch back into mine and deliver them both into master. I'll let Dave finish it and i'll take a quick look after to make sure i don't have any bugs left then i'll change the status into done for this branch.

ghost commented 9 years ago

Ok. I have merged my branch into andreas-newpost-newattachment.

byennen commented 9 years ago

any chance this is ready?

afruth commented 9 years ago

@byennen not yet. After Dave finishes his pass i'll need another hour to test stuffs and then it's ready.

byennen commented 9 years ago

@afruth cool. thanks! selfie-0

byennen / one

Andreas/Dave/Jonas newpost newattachment [DONE] #72