search

byjg / docker-easy-haproxy

Discover services and create dynamically the haproxy.cfg based on the labels defined in docker containers or from a simple static Yaml
MIT License
56 stars 13 forks source link

Add ability to customize the label prefix #11

Closed josegonzalez closed 2 years ago

josegonzalez commented 2 years ago

Hi! I'm looking at ways to add new proxy implementations for Dokku, and this repo is in-line with what I'm doing around Caddy and Traefik.

One thing I'd like to do is change the label prefix to haproxy instead of easyhaproxy. I believe this will make it easier for developers to integrate with (since they'll know what haproxy is).

Would it be possible to expose an environment variable for customizing the label prefix?

byjg commented 2 years ago

I am glad to know that it is aligned with the Dokku project.

The change you ask for is not difficult at all. There is one place I have to change. But I have to make some changes in the documentation, add new unit tests, create an environment variable to make it customizable, etc.

Before putting my hands on it, I'd like to understand why the label rename can positively impact the APP.

josegonzalez commented 2 years ago

While not now, I figure that in the future, it may be possible for users to customize other parts of the haproxy config via app labels. They might do so like this:

dokku docker-options:add node-js-app deploy "--label easyhaproxy.some-key=value"

The proxy plugin itself would be named haproxy, so it would make sense for someone to run this instead:

dokku docker-options:add node-js-app deploy "--label haproxy.some-key=value"

All other plugin integrations use the underlying service name (caddy or traefik) as the label prefix. I'd like to avoid a user bashing their head in because they used the wrong prefix.

byjg commented 2 years ago

OK. I'll do that. Probably next week have that. So, just to let you know, the default will be easyhaproxy, and we will be able to override it by setting an environment variable in the easyhaproxy container. Does it make sense?

byjg commented 2 years ago

OR... are you planning to integrate inside the Dokku project as part of the project? If you are planning to do that, I can change the default to haproxy.

josegonzalez commented 2 years ago

No I'm going to start your container via a custom compose file. I can reconfigure it as necessary :)

byjg commented 2 years ago

I added PR #14 with the requirements you ask. You have to add the environment variable LOOKUP_LABEL to your easyhaproxy container.

Here is an example: https://github.com/byjg/docker-easy-haproxy/blob/73ced05228c6342444bff6e121ed86cd6460d443/examples/docker/docker-compose-changed-label.yml

I still have to do some work to package it, but you can start your tests if you want.

byjg commented 2 years ago

All merged. You can docker pull byjg/easy-haproxy:4.0.0. See release notes of the implemented features: https://github.com/byjg/docker-easy-haproxy/releases/tag/4.0.0