search

byjg / docker-easy-haproxy

Discover services and create dynamically the haproxy.cfg based on the labels defined in docker containers or from a simple static Yaml
MIT License
56 stars 13 forks source link

[Feature Request] Add support for setting the prefered Challenge #56

Open ThaDaVos opened 2 weeks ago

ThaDaVos commented 2 weeks ago

Currently it seems the call to Certbot is hardcoded: https://github.com/byjg/docker-easy-haproxy/blob/1a6853487ec9aabcb241f3c9e263313138378b0c/src/functions/__init__.py#L339-L354

Could this be opened up so one can configure the parameters on a container basis with labels? In my case, I want to change the preferred challenge from HTTP to DNS and use acme-dns to resolve it: https://github.com/joohoi/acme-dns With hook: https://github.com/koesie10/acme-dns-certbot-hook

ThaDaVos commented 2 weeks ago

Created a PR: https://github.com/byjg/docker-easy-haproxy/pull/57