search

bylee20 / bomi

bomi - a powerful and easy-to-use multimedia player
http://bomi-player.github.io
Other
426 stars 89 forks source link

Video quality issue in windowed mode. #282

Closed mac1202 closed 9 years ago

mac1202 commented 9 years ago

Hi i got an issue with bomi the image quality in windowed mode are really poor especially on dark scene. Here a screenshot in windowed mode : http://i.imgur.com/6iWBqNk.png And the same scene in fullscreen : http://i.imgur.com/BOrg2MF.png Try with standalone mpv and didn't get the issue. Edit : Disabling high quality scaling > upscaling fixed it. Isn't this suposed to improved image quality ?

bylee20 commented 9 years ago

If you changed something in Video menu, please try in default state. Especially, confirm next:

mac1202 commented 9 years ago

I edited my report High Quality Scaling > upscaling was the culprit but isn't this suposed to improved image quality ?

mac1202 commented 9 years ago

Do you now what option High Quality Scaling > upscaling pass to mpv so i can test if the result is the same in mpv ?

bylee20 commented 9 years ago

That's good idea. I have a hunch. Please try next options and let me know the result:

  1. mpv --vo=opengl:fbo-format=rgba16:sigmoid-upscaling
  2. mpv --vo=opengl:fbo-format=rgba:sigmoid-upscaling
mac1202 commented 9 years ago

ok so

  1. with this option no problem the quality is fine
  2. i got the same poor quality in windowed mode as with bomi
bylee20 commented 9 years ago

That's exactly what I expected. Thank you for report & test. I should've enforced 16bit fbo for hq upscaling.

bylee20 commented 9 years ago

Fixed. Thank you!