Please bundle mpv as a submodule instead of copying it in

bylee20 / bomi

bomi - a powerful and easy-to-use multimedia player

http://bomi-player.github.io

Other

425 stars 89 forks source link

Please bundle mpv as a submodule instead of copying it in #475

Open yurivict opened 8 years ago

yurivict commented 8 years ago

I am trying to make a port on FreeBSD. Build it fails in mpv build. Having a copy of some mpv version is a bad idea because it isn't obvious what this version is. Additionally, I already have mpv installed. Why do I need to build it again?

You should:

replace the bundled copy with a git submodule of mpv pointing to a particular version in https://github.com/mpv-player/mpv
consider allowing an external version of mpv through the configure option

AsukaLangleyfag commented 8 years ago

You should've read https://github.com/xylosper/bomi/wiki/bomi-is-not-a-front-end

bomi uses customized built-in mpv

and

Ergo, bomi is not separable from mpv, and obviously, bomi is not a front end. Since built-in mpv shares most of code from original one, I prefer the expression mpv-based player. However, if you want to define bomi, bomi is more like a fork rather than front end.

yurivict commented 8 years ago

Still, you could have mpv as a submodule + a set of patches. Then patch it as a part of a build. This way it would have been easier to update mpv, and to see what version of mpv is used.