Closed kalmarek closed 10 years ago
Oh, I'm sorry to be late to check your pull request. About a month ago, my laptop was broken and finally I've got new computer! I have made some change to support Okular 0.20 and it made your pull request not mergable. Can you make it mergable again?
Sure, here it is;
I'm not sure if commit e8544ee is correct. It works, but shouldn't we rather check whether loadPages(pages) succeeded? well the function is void, so I didn't know how to do it.
I've added something like this in f9cdc22 fill free to revert
btw. have You thought of adding links to the back-end? I'd like to but my c++ is way to weak...
I'm not sure if commit e8544ee is correct. It works, but shouldn't we rather check whether loadPages(pages) succeeded? well the function is void, so I didn't know how to do it.
As far as I can see, there's no way to check any error in loadPages. The function just allocates some Okular::Page objects so, there cannot be any error except out of memory which will be never checked.
I've added something like this in f9cdc22 fill free to revert
Looks fine althoug I prefer one line like if (!m_pdfdoc.isLocked())
. Thanks.
btw. have You thought of adding links to the back-end?
You mean hyperlink?
I changed if to the form you like more
Yes, I meant hyperlinks
Thank you! I'll release this as 0.0.3. Yes, I want to implement hyperlink but no idea yet.
It seems the encoding of files which you added is not compatible with UTF-8. What encoding do you use?
Well it seems to me that I use UTF-8
I use kdevelop and in Editor > Tools > Encoding I see Unicode > UTF-8
Settings > Configure Editor > Open/Save Also indicates Unicode(UTF-8)
Marek Kaluba, PhD Adam Mickiewicz Univeristy Faculty of Mathematics and Computer Science ul. Umultowska 87 61-614 Poznań, Poland
On Tuesday 02 September 2014 20:00:31 xylosper wrote:
It seems the encoding of files which you added is not compatible with UTF-8. What encoding do you use?
Reply to this email directly or view it on GitHub: https://github.com/xylosper/okular-backend-mupdf/pull/1#issuecomment-5424655 6
Well, in that case, maybe some kind of special character has been insterted by acident. Anyway, thanks!
Copied synctex support from poppler generator;
It works fine with kile-from-git-live-preview (even better due to dpi factors (?) tuning)