Closed LuigiPulcini closed 5 months ago
Hi, @bylexus.
First of all, thank you so much for promptly reviewing my pull request. I am sorry I completely missed the fact that the tests would all fail with the library refactoring in Typescript.
I have now adjusted a few more details in the library and fixed all the tests accordingly. When I run npm run test
, everything runs smoothly, now.
Hi @LuigiPulcini,
Thanks for your contribution, this is a valuable addition. I did some adaptions to your original pull request, mostly type definitions and some documentation.
For the time being, I merged it back to the develop
branch, I want to implement some additional changes before merging it to the main and creating a version, namely:
As soon as I added those additions, I will publish a new version.
If there is any interest in adding support for string parameters and variables, this PR adjusts the version forked by @issidorov (https://github.com/issidorov/fparse/), updating it to the latest master branch (including the refactoring to Typescript).
This is also requested in #51.
An example of what this version can do is offered below:
I hope this helps.